Bug Armor not working?

[dforth123]

Hey, recently armor reduction has been broken! Please look at this video below.

 

[Dakinara]

hmmm i thought i was dying fast...er than usual hehe

Also, just confirmed with shadow, armor appears to be doing nothing to left click attacks - 38 dmg per hit with no armor, 38 dmg hit with 55% dmg reduction

 

[Kainzo]

@Coders - only thing really changed was an update to latest spigot/bukkit

We may have something in Heroes not handling the damage properly...

 

[Ruger392]

The dmg reduction is also affected in pve

 

[xMJay]

Zombies take full damage and deal full damage

 

[xMJay]

skills like strike are dealing armor reduced damage only the left click damage is broken

 

[Yavool]

When it was stated that protection was going to be removed from the game, they weren't kidding!

 

[Kainzo]

[USERGROUP=15]@Coders[/USERGROUP]
https://github.com/Bukkit/Bukkit/commit/c025253012df338fcca70a79410989a65555a7e3

@t00thpick1

Is because of armor/other damage modifiers being added to the damage event which gives much more access to stuff, but also means its calculated pre-event rather than post event.. // Which, while an inconvienence to update to, opens up much more possibilities // But pre-this change all that stuff didn't even exist as far as the API was concerned // it just happened to work for their benefit // magically, rather than purposefully

 

[Sleaker]

[USERGROUP=15][USERGROUP=15][USERGROUP=15]@Coders[/USERGROUP][/USERGROUP][/USERGROUP]
https://github.com/Bukkit/Bukkit/commit/c025253012df338fcca70a79410989a65555a7e3

@t00thpick1

Armor wont work until the damage handlers are completely re-written. They now have BaseModifier etc set per damage-type and the modifiers include how much damage is being blocked etc.

They also closed some other issues I posted about 0 damage events triggering, events triggering for monsters that have NoDamageTicks above threshhold etc, so these may or may not be fixed.

 

[Kainzo]

Armor wont work until the damage handlers are completely re-written. They now have BaseModifier etc set per damage-type and the modifiers include how much damage is being blocked etc.

Yeah, so im lookin at reverting the last 50+ commits in Heroes requiring the new Vault stuff, not sure whats the best way to do this.

 

[Sleaker]

Yeah, so im lookin at reverting the last 50+ commits in Heroes requiring the new Vault stuff, not sure whats the best way to do this.

why would you revert the Vault stuff?

 

[Kainzo]

Working on reverting this.
http://git.hc.to/herocraft/heroes/commit/ec46cf5ac2b96478743f618b4f3a10aafef14253

This will be fixed tomorrow until we have time to rewrite this.